lkml.org 
[lkml]   [2017]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv2 4/5] perf stat: Add -a as a default target
On Sat, Feb 18, 2017 at 06:52:25PM +0100, Borislav Petkov wrote:
> On Fri, Feb 17, 2017 at 06:48:13PM +0100, Boris Petkov wrote:
> > LGTM.
> >
> > Acked-by: me
>
> Well, it looks good but actually trying it is a different story. For
> example:
>
> $ ./perf stat -e amd_nb/event=0xe0,umask=0x1f/ sleep 1
>
> still says <not supported> because argc is not 0.
>
> So how about the below diff instead?
>
> $ ./perf stat -e amd_nb/event=0xe0,umask=0x1f/
>
> without args dumps the usage message and
>
> $ ./perf stat -e amd_nb/event=0xe0,umask=0x1f/ sleep 1
>
> actually does the system-wide thing:
>
> Performance counter stats for 'system wide':
>
> 196,469 amd_nb/event=0xe0,umask=0x1f/
>
> 1.001815180 seconds time elapsed
>
> Hmmm?

ugh, I thought it was too easy ;-)

it looks good to me

thanks,
jirka

\
 
 \ /
  Last update: 2017-02-20 08:13    [W:1.044 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site