lkml.org 
[lkml]   [2017]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH v2] tools/vm: Fix possible resource leak in page_owner_sort.c
The patch addresses explicit closing of file pointers on exit
and redirects the errors to the stderr
Signed-off-by: Saurabh Badhwar <sbsaurabhbadhwar9@gmail.com>
---
tools/vm/page_owner_sort.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/vm/page_owner_sort.c b/tools/vm/page_owner_sort.c
index 8346261..b3c3efa 100644
--- a/tools/vm/page_owner_sort.c
+++ b/tools/vm/page_owner_sort.c
@@ -109,7 +109,7 @@ int main(int argc, char **argv)
list = malloc(max_size * sizeof(*list));
buf = malloc(BUF_SIZE);
if (!list || !buf) {
- printf("Out of memory\n");
+ perror("Unable to allocate memory: ");
fclose(fin);
fclose(fout);
exit(1);
@@ -145,8 +145,8 @@ int main(int argc, char **argv)
qsort(list2, count, sizeof(list[0]), compare_num);

for (i = 0; i < count; i++)
- fprintf(fout, "%d times:\n%s\n", list2[i].num, list2[i].txt);
-
+ fprintf(fout, "%d times:\n%s\n", list2[i].num, list2[i].txt);
+
fclose(fout);
return 0;
}
--
2.9.3
\
 
 \ /
  Last update: 2017-02-20 11:47    [W:2.708 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site