lkml.org 
[lkml]   [2017]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [Letux-kernel] [PATCH v9 1/8] drivers:input:tsc2007: add new common binding names, pre-calibration, flipping and rotation
    Hi!

    > > > And note that I am not making things different from others in tree,
    > > > I am making the tsc2007 right (incl. following the touchscreen
    > > > bindings which define the touchscreen size in "Pixels").
    > >
    > > Your touch screen is not in any way special, so it has to behave in
    > > the same way others do.
    > >
    >
    > I agree, the tsc2007 (=what the interface provides to userspace) should
    > not behave special, for example it should behave like the virtual
    > touchscreen (=what the interface provides to userspace) virtualbox
    > gives. No need to be calibrated. Well, the internals are different. But
    > that is what the kernel is good for, abstract such things.
    > Conclusion: It cannot be totally wrong behavior to have pixel values
    > there.

    It is not "totally wrong". But it is useless code that should not be
    in kernel. Calibration certainly does not belong to single
    _driver_. Feel free to submit driver but keep the calibration code out
    of tree...

    But if you have userspace that depends on touchscreen to be
    calibrated... that _is_ wrong.

    Pavel
    --
    (english) http://www.livejournal.com/~pavelmachek
    (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2017-02-19 23:40    [W:2.520 / U:0.132 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site