lkml.org 
[lkml]   [2017]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 197/306] uwb: fix device reference leaks
    3.16.40-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Johan Hovold <johan@kernel.org>

    commit d6124b409ca33c100170ffde51cd8dff761454a1 upstream.

    This subsystem consistently fails to drop the device reference taken by
    class_find_device().

    Note that some of these lookup functions already take a reference to the
    returned data, while others claim no reference is needed (or does not
    seem need one).

    Fixes: 183b9b592a62 ("uwb: add the UWB stack (core files)")
    Signed-off-by: Johan Hovold <johan@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/uwb/lc-rc.c | 16 +++++++++++++---
    drivers/uwb/pal.c | 2 ++
    2 files changed, 15 insertions(+), 3 deletions(-)

    --- a/drivers/uwb/lc-rc.c
    +++ b/drivers/uwb/lc-rc.c
    @@ -56,8 +56,11 @@ static struct uwb_rc *uwb_rc_find_by_ind
    struct uwb_rc *rc = NULL;

    dev = class_find_device(&uwb_rc_class, NULL, &index, uwb_rc_index_match);
    - if (dev)
    + if (dev) {
    rc = dev_get_drvdata(dev);
    + put_device(dev);
    + }
    +
    return rc;
    }

    @@ -368,7 +371,9 @@ struct uwb_rc *__uwb_rc_try_get(struct u
    if (dev) {
    rc = dev_get_drvdata(dev);
    __uwb_rc_get(rc);
    + put_device(dev);
    }
    +
    return rc;
    }
    EXPORT_SYMBOL_GPL(__uwb_rc_try_get);
    @@ -421,8 +426,11 @@ struct uwb_rc *uwb_rc_get_by_grandpa(con

    dev = class_find_device(&uwb_rc_class, NULL, grandpa_dev,
    find_rc_grandpa);
    - if (dev)
    + if (dev) {
    rc = dev_get_drvdata(dev);
    + put_device(dev);
    + }
    +
    return rc;
    }
    EXPORT_SYMBOL_GPL(uwb_rc_get_by_grandpa);
    @@ -454,8 +462,10 @@ struct uwb_rc *uwb_rc_get_by_dev(const s
    struct uwb_rc *rc = NULL;

    dev = class_find_device(&uwb_rc_class, NULL, addr, find_rc_dev);
    - if (dev)
    + if (dev) {
    rc = dev_get_drvdata(dev);
    + put_device(dev);
    + }

    return rc;
    }
    --- a/drivers/uwb/pal.c
    +++ b/drivers/uwb/pal.c
    @@ -97,6 +97,8 @@ static bool uwb_rc_class_device_exists(s

    dev = class_find_device(&uwb_rc_class, NULL, target_rc, find_rc);

    + put_device(dev);
    +
    return (dev != NULL);
    }

    \
     
     \ /
      Last update: 2017-02-16 00:47    [W:4.386 / U:1.668 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site