lkml.org 
[lkml]   [2017]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tpm: declare tpm2_get_pcr_allocation() as static
On Wed, Feb 15, 2017 at 11:56:43AM -0700, Jason Gunthorpe wrote:
> On Wed, Feb 15, 2017 at 08:02:28PM +0200, Jarkko Sakkinen wrote:
> > There's no need to export tpm2_get_pcr_alloation() because it is only
> > a helper function for tpm2_auto_startup(). For the same reason it does
> > not make much sense to maintain documentation for it.
>
> Please stop moving these functions around, you are just breaking the
> git history and git blame - there cosmetic reason of having a certain
> order is not worth this damage.
>
> Jason

So you rather want a predeclaration?

Moving code for the right reasons is perfectly justifiable.

/Jarkko

\
 
 \ /
  Last update: 2017-02-15 20:08    [W:0.092 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site