Messages in this thread | | | Date | Wed, 15 Feb 2017 21:06:48 +0200 | From | Jarkko Sakkinen <> | Subject | Re: [PATCH] tpm: declare tpm2_get_pcr_allocation() as static |
| |
On Wed, Feb 15, 2017 at 11:56:43AM -0700, Jason Gunthorpe wrote: > On Wed, Feb 15, 2017 at 08:02:28PM +0200, Jarkko Sakkinen wrote: > > There's no need to export tpm2_get_pcr_alloation() because it is only > > a helper function for tpm2_auto_startup(). For the same reason it does > > not make much sense to maintain documentation for it. > > Please stop moving these functions around, you are just breaking the > git history and git blame - there cosmetic reason of having a certain > order is not worth this damage. > > Jason
So you rather want a predeclaration?
Moving code for the right reasons is perfectly justifiable.
/Jarkko
| |