lkml.org 
[lkml]   [2017]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] m32r: mm: fix build warning
On Tue, Feb 14, 2017 at 02:15:51PM -0800, Andrew Morton wrote:
> On Tue, 14 Feb 2017 22:05:45 +0000 Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote:
>
> > The build of m32r was giving warning:
> > mm/pgtable-generic.c: In function 'ptep_clear_flush':
> > mm/pgtable-generic.c:76:20: warning:
> > unused variable 'mm' [-Wunused-variable]
> >
> > The implementation of ptep_get_and_clear() and pte_accessible()
> > does not use 'mm'.
>
> That's because ptep_get_and_clear() and pte_accessible() are
> implemented as macros. If they were (static inline) C functions then
> this warning wouldn't occur. All the other architectures get this
> right.

oops.. sorry.. usually I will check all the other arch before sending a
patch but missed it this time.
Will investigate further today and send you a modified patch.

Regards
Sudip

\
 
 \ /
  Last update: 2017-02-15 12:38    [W:0.827 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site