lkml.org 
[lkml]   [2017]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 243/306] IB/mlx5: Fix NULL pointer dereference on debug print
    3.16.40-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Eli Cohen <eli@mellanox.com>

    commit a1ab8402d15d2305d2315d96ec3294bfdf16587e upstream.

    For XRC QP CQs may not exist. Check before attempting dereference.

    Fixes: e126ba97dba9 ('mlx5: Add driver for Mellanox Connect-IB adapters')
    Signed-off-by: Eli Cohen <eli@mellanox.com>
    Signed-off-by: Maor Gottlieb <maorg@mellanox.com>
    Reviewed-by: Yishai Hadas <yishaih@mellanox.com>
    Signed-off-by: Leon Romanovsky <leon@kernel.org>
    Signed-off-by: Doug Ledford <dledford@redhat.com>
    [bwh: Backported to 3.16: adjust context]
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    --- a/drivers/infiniband/hw/mlx5/qp.c
    +++ b/drivers/infiniband/hw/mlx5/qp.c
    @@ -1205,8 +1205,9 @@ struct ib_qp *mlx5_ib_create_qp(struct i
    qp->ibqp.qp_num = qp->mqp.qpn;

    mlx5_ib_dbg(dev, "ib qpnum 0x%x, mlx qpn 0x%x, rcqn 0x%x, scqn 0x%x\n",
    - qp->ibqp.qp_num, qp->mqp.qpn, to_mcq(init_attr->recv_cq)->mcq.cqn,
    - to_mcq(init_attr->send_cq)->mcq.cqn);
    + qp->ibqp.qp_num, qp->mqp.qpn,
    + init_attr->recv_cq ? to_mcq(init_attr->recv_cq)->mcq.cqn : -1,
    + init_attr->send_cq ? to_mcq(init_attr->send_cq)->mcq.cqn : -1);

    qp->xrcdn = xrcdn;

    \
     
     \ /
      Last update: 2017-02-16 01:27    [W:3.148 / U:0.640 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site