lkml.org 
[lkml]   [2017]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 088/306] UBI: fastmap: scrub PEB when bitflips are detected in a free PEB EC header
    3.16.40-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Boris Brezillon <boris.brezillon@free-electrons.com>

    commit ecbfa8eabae9cd73522d1d3d15869703c263d859 upstream.

    scan_pool() does not mark the PEB for scrubing when bitflips are
    detected in the EC header of a free PEB (VID header region left to
    0xff).
    Make sure we scrub the PEB in this case.

    Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
    Fixes: dbb7d2a88d2a ("UBI: Add fastmap core")
    Signed-off-by: Richard Weinberger <richard@nod.at>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/mtd/ubi/fastmap.c | 7 ++++---
    1 file changed, 4 insertions(+), 3 deletions(-)

    --- a/drivers/mtd/ubi/fastmap.c
    +++ b/drivers/mtd/ubi/fastmap.c
    @@ -445,10 +445,11 @@ static int scan_pool(struct ubi_device *
    unsigned long long ec = be64_to_cpu(ech->ec);
    unmap_peb(ai, pnum);
    dbg_bld("Adding PEB to free: %i", pnum);
    +
    if (err == UBI_IO_FF_BITFLIPS)
    - add_aeb(ai, free, pnum, ec, 1);
    - else
    - add_aeb(ai, free, pnum, ec, 0);
    + scrub = 1;
    +
    + add_aeb(ai, free, pnum, ec, scrub);
    continue;
    } else if (err == 0 || err == UBI_IO_BITFLIPS) {
    dbg_bld("Found non empty PEB:%i in pool", pnum);
    \
     
     \ /
      Last update: 2017-02-16 01:06    [W:4.058 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site