lkml.org 
[lkml]   [2017]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 1/2] HID: reject input outside logical range only if null state is set
    Date
    From: Valtteri Heikkilä <rnd@nic.fi>

    This patch fixes an issue in drivers/hid/hid-input.c where USB HID
    control null state flag is not checked upon rejecting inputs outside
    logical minimum-maximum range. The check should be made according to USB
    HID specification 1.11, section 6.2.2.5, p.31. The fix will resolve
    issues with some game controllers, such as:
    https://bugzilla.kernel.org/show_bug.cgi?id=68621

    [tk@the-tk.com: shortened and fixed spelling in commit message]
    Signed-off-by: Valtteri Heikkilä <rnd@nic.fi>
    Signed-off-by: Tomasz Kramkowski <tk@the-tk.com>
    ---
    drivers/hid/hid-input.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
    index d05f903c7614..cf8256aac2bd 100644
    --- a/drivers/hid/hid-input.c
    +++ b/drivers/hid/hid-input.c
    @@ -1157,6 +1157,7 @@ void hidinput_hid_event(struct hid_device *hid, struct hid_field *field, struct
    * don't specify logical min and max.
    */
    if ((field->flags & HID_MAIN_ITEM_VARIABLE) &&
    + (field->flags & HID_MAIN_ITEM_NULL_STATE) &&
    (field->logical_minimum < field->logical_maximum) &&
    (value < field->logical_minimum ||
    value > field->logical_maximum)) {
    --
    2.11.0
    \
     
     \ /
      Last update: 2017-02-15 00:22    [W:3.986 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site