Messages in this thread | | | Date | Tue, 14 Feb 2017 22:29:15 +0000 | From | Jason Cooper <> | Subject | Re: [PATCH] irqchip: mvebu-odmi: select GENERIC_MSI_IRQ_DOMAIN |
| |
Hi Arnd,
On Tue, Feb 14, 2017 at 10:24:36PM +0100, Arnd Bergmann wrote: > This driver uses the MSI domain but has no strict dependency on PCI_MSI, so we > may run into a build failure when CONFIG_GENERIC_MSI_IRQ_DOMAIN is disabled: > > drivers/irqchip/irq-mvebu-odmi.c:152:15: error: variable 'odmi_msi_ops' has initializer but incomplete type > static struct msi_domain_ops odmi_msi_ops = { > ^~~~~~~~~~~~~~ > drivers/irqchip/irq-mvebu-odmi.c:155:15: error: variable 'odmi_msi_domain_info' has initializer but incomplete type > static struct msi_domain_info odmi_msi_domain_info = { > ^~~~~~~~~~~~~~~ > drivers/irqchip/irq-mvebu-odmi.c:156:3: error: 'struct msi_domain_info' has no member named 'flags' > .flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS), > ^~~~~ > drivers/irqchip/irq-mvebu-odmi.c:156:12: error: 'MSI_FLAG_USE_DEF_DOM_OPS' undeclared here (not in a function) > .flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS), > ^~~~~~~~~~~~~~~~~~~~~~~~ > drivers/irqchip/irq-mvebu-odmi.c:156:39: error: 'MSI_FLAG_USE_DEF_CHIP_OPS' undeclared here (not in a function); did you mean 'MSI_FLAG_USE_DEF_DOM_OPS'? > > Selecting the option from this driver seems to solve this nicely, though I could > not find any other instance of this in irqchip drivers. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/irqchip/Kconfig | 1 + > 1 file changed, 1 insertion(+)
right-o, I think it's fine here as it's obviously a direct dependency. I'll queue this up.
thx,
Jason.
| |