Messages in this thread | | | Date | Tue, 14 Feb 2017 10:08:45 -0800 | From | Greg KH <> | Subject | Re: [PATCH] staging: fwserial: replace 'a' with '(a)' to avoid precedence issues |
| |
On Tue, Feb 14, 2017 at 11:26:20PM +0530, Arushi Singhal wrote: > Macro argument 'a' may be better as '(a)' to avoid precedence issues as > reported by checkpatch.pl > > Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com> > --- > drivers/staging/fwserial/fwserial.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/fwserial/fwserial.c b/drivers/staging/fwserial/fwserial.c > index 41a49c8194e5..bdfc0a8c7af3 100644 > --- a/drivers/staging/fwserial/fwserial.c > +++ b/drivers/staging/fwserial/fwserial.c > @@ -98,7 +98,7 @@ struct fwtty_transaction { > }; > }; > > -#define to_device(a, b) (a->b) > +#define to_device((a), b) (a->b)
Really? Why do we even have this macro at all? Can it just be removed?
thanks,
greg k-h
| |