lkml.org 
[lkml]   [2017]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH V2 2/2] powerpc/mm/autonuma: Switch ppc64 to its own implementeation of saved write
    Date
    "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> writes:
    > diff --git a/arch/powerpc/include/asm/book3s/64/mmu-hash.h b/arch/powerpc/include/asm/book3s/64/mmu-hash.h
    > index 0735d5a8049f..8720a406bbbe 100644
    > --- a/arch/powerpc/include/asm/book3s/64/mmu-hash.h
    > +++ b/arch/powerpc/include/asm/book3s/64/mmu-hash.h
    > @@ -16,6 +16,9 @@
    > #include <asm/page.h>
    > #include <asm/bug.h>
    >
    > +#ifndef __ASSEMBLY__
    > +#include <linux/mmdebug.h>
    > +#endif

    I assume that's for the VM_BUG_ON() you add below. But if so wouldn't
    the #include be better placed in book3s/64/pgtable.h also?

    > diff --git a/arch/powerpc/include/asm/book3s/64/pgtable.h b/arch/powerpc/include/asm/book3s/64/pgtable.h
    > index fef738229a68..c684ef6cbd10 100644
    > --- a/arch/powerpc/include/asm/book3s/64/pgtable.h
    > +++ b/arch/powerpc/include/asm/book3s/64/pgtable.h
    > @@ -512,6 +512,32 @@ static inline pte_t pte_mkhuge(pte_t pte)
    > return pte;
    > }
    >
    > +#define pte_mk_savedwrite pte_mk_savedwrite
    > +static inline pte_t pte_mk_savedwrite(pte_t pte)
    > +{
    > + /*
    > + * Used by Autonuma subsystem to preserve the write bit
    > + * while marking the pte PROT_NONE. Only allow this
    > + * on PROT_NONE pte
    > + */
    > + VM_BUG_ON((pte_raw(pte) & cpu_to_be64(_PAGE_PRESENT | _PAGE_RWX | _PAGE_PRIVILEGED)) !=
    > + cpu_to_be64(_PAGE_PRESENT | _PAGE_PRIVILEGED));
    > + return __pte(pte_val(pte) & ~_PAGE_PRIVILEGED);
    > +}
    > +


    cheers

    \
     
     \ /
      Last update: 2017-02-14 19:07    [W:3.115 / U:0.308 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site