Messages in this thread | | | Date | Mon, 13 Feb 2017 13:53:50 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 4/5] IB/hfi1: Use memdup_user() rather than duplicating its implementation in hfi1_user_sdma_process_request() |
| |
On Sat, Feb 11, 2017 at 10:32:59AM -0500, Dennis Dalessandro wrote: > On 02/10/2017 04:04 PM, SF Markus Elfring wrote: > >From: Markus Elfring <elfring@users.sourceforge.net> > >Date: Fri, 10 Feb 2017 21:01:55 +0100 > > > >Reuse existing functionality from memdup_user() instead of keeping > >duplicate source code. > > > >Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > > Thanks for the patch, but this one is already taken care of along > with other similar uses of kmalloc/copy: > > http://marc.info/?l=linux-rdma&m=148656088729538&w=2 >
Michael's patch doesn't change user_sdma_free_request() so it introduces a kfreeing an error pointer bug.
regards, dan carpenter
| |