lkml.org 
[lkml]   [2017]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH 05/33] irqchip/gic-v3-its: Zero command on allocation
    On Tue, 17 Jan 2017, Marc Zyngier wrote:

    > When reusing commands from the ring buffer, it would be better
    > to zero them out, even if the ITS should ignore the unused
    > fields.
    >
    > Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
    > ---
    > drivers/irqchip/irq-gic-v3-its.c | 6 ++++++
    > 1 file changed, 6 insertions(+)
    >
    > diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
    > index 2ca27f6..9304dd2 100644
    > --- a/drivers/irqchip/irq-gic-v3-its.c
    > +++ b/drivers/irqchip/irq-gic-v3-its.c
    > @@ -426,6 +426,12 @@ static struct its_cmd_block *its_allocate_entry(struct its_node *its)
    > if (its->cmd_write == (its->cmd_base + ITS_CMD_QUEUE_NR_ENTRIES))
    > its->cmd_write = its->cmd_base;
    >
    > + /* Clear command */
    > + cmd->raw_cmd[0] = 0;
    > + cmd->raw_cmd[1] = 0;
    > + cmd->raw_cmd[2] = 0;
    > + cmd->raw_cmd[3] = 0;

    memset ?

    Thanks,

    tglx

    \
     
     \ /
      Last update: 2017-02-13 10:56    [W:4.198 / U:0.548 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site