lkml.org 
[lkml]   [2017]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 18/25] Staging: rtl8192u: ieee80211: rtl819x_HT.h - style fix
On Sat, Feb 11, 2017 at 10:57:28PM +1300, Derek Robson wrote:
> Fixed style of block comments
> Found using checkpatch
>
> Signed-off-by: Derek Robson <robsonde@gmail.com>
> ---
> drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h | 69 +++++++++++++------------
> 1 file changed, 35 insertions(+), 34 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h b/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h
> index c3aabbaac7ae..307ab45f528d 100644
> --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h
> +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h
> @@ -86,38 +86,38 @@ typedef enum _CHNLOP{
> ((_pHTInfo)->ChnlOp > CHNLOP_NONE) ? TRUE : FALSE
>
> /*
> -typedef union _HT_CAPABILITY{
> - u16 ShortData;
> - u8 CharData[2];
> - struct
> - {
> - u16 AdvCoding:1;
> - u16 ChlWidth:1;
> - u16 MimoPwrSave:2;
> - u16 GreenField:1;
> - u16 ShortGI20Mhz:1;
> - u16 ShortGI40Mhz:1;
> - u16 STBC:1;
> - u16 BeamForm:1;
> - u16 DelayBA:1;
> - u16 MaxAMSDUSize:1;
> - u16 DssCCk:1;
> - u16 PSMP:1;
> - u16 Rsvd:3;
> - }Field;
> -}HT_CAPABILITY, *PHT_CAPABILITY;
> -
> -typedef union _HT_CAPABILITY_MACPARA{
> - u8 ShortData;
> - u8 CharData[1];
> - struct
> - {
> - u8 MaxRxAMPDU:2;
> - u8 MPDUDensity:2;
> - u8 Rsvd:4;
> - }Field;
> -}HT_CAPABILITY_MACPARA, *PHT_CAPABILITY_MACPARA;
> -*/
> + * typedef union _HT_CAPABILITY{
> + * u16 ShortData;
> + * u8 CharData[2];
> + * struct
> + * {
> + * u16 AdvCoding:1;
> + * u16 ChlWidth:1;
> + * u16 MimoPwrSave:2;
> + * u16 GreenField:1;
> + * u16 ShortGI20Mhz:1;
> + * u16 ShortGI40Mhz:1;
> + * u16 STBC:1;
> + * u16 BeamForm:1;
> + * u16 DelayBA:1;
> + * u16 MaxAMSDUSize:1;
> + * u16 DssCCk:1;
> + * u16 PSMP:1;
> + * u16 Rsvd:3;
> + * }Field;
> + * }HT_CAPABILITY, *PHT_CAPABILITY;
> + *
> + * typedef union _HT_CAPABILITY_MACPARA{
> + * u8 ShortData;
> + * u8 CharData[1];
> + * struct
> + * {
> + * u8 MaxRxAMPDU:2;
> + * u8 MPDUDensity:2;
> + * u8 Rsvd:4;
> + * }Field;
> + * }HT_CAPABILITY_MACPARA, *PHT_CAPABILITY_MACPARA;
> + */
>
> typedef enum _HT_ACTION{
> ACT_RECOMMAND_WIDTH = 0,

I'll take this, but shouldn't we just delete these structures that are
commented out? Same goes for other patches in this series.

thanks,

greg k-h

\
 
 \ /
  Last update: 2017-02-12 13:32    [W:0.518 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site