Messages in this thread Patch in this message | | | Date | Thu, 9 Feb 2017 23:53:08 -0800 | From | tip-bot for Arnaldo Carvalho de Melo <> | Subject | [tip:perf/core] tools string: Use __fallthrough in perf_atoll() |
| |
Commit-ID: 94bdd5edb34e472980d1e18b4600d6fb92bd6b0a Gitweb: http://git.kernel.org/tip/94bdd5edb34e472980d1e18b4600d6fb92bd6b0a Author: Arnaldo Carvalho de Melo <acme@redhat.com> AuthorDate: Wed, 8 Feb 2017 17:01:46 -0300 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Wed, 8 Feb 2017 17:31:01 -0300
tools string: Use __fallthrough in perf_atoll()
The implicit fall through case label here is intended, so let us inform that to gcc >= 7:
CC /tmp/build/perf/util/string.o util/string.c: In function 'perf_atoll': util/string.c:22:7: error: this statement may fall through [-Werror=implicit-fallthrough=] if (*p) ^ util/string.c:24:3: note: here case '\0': ^~~~
Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: David Ahern <dsahern@gmail.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Wang Nan <wangnan0@huawei.com> Link: http://lkml.kernel.org/n/tip-0ophb30v9apkk6o95el0rqlq@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/util/string.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/tools/perf/util/string.c b/tools/perf/util/string.c index d8dfaf6..bddca51 100644 --- a/tools/perf/util/string.c +++ b/tools/perf/util/string.c @@ -21,6 +21,8 @@ s64 perf_atoll(const char *str) case 'b': case 'B': if (*p) goto out_err; + + __fallthrough; case '\0': return length; default:
| |