Messages in this thread | | | Date | Sat, 11 Feb 2017 03:08:41 +0200 | From | Ivan Khoronzhuk <> | Subject | Re: [PATCH] net: ethernet: ti: netcp_core: return netdev_tx_t in xmit |
| |
On Fri, Feb 10, 2017 at 02:45:21PM -0500, David Miller wrote: > From: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> > Date: Thu, 9 Feb 2017 16:24:14 +0200 > > > @@ -1300,7 +1301,7 @@ static int netcp_ndo_start_xmit(struct sk_buff *skb, struct net_device *ndev) > > dev_warn(netcp->ndev_dev, "padding failed (%d), packet dropped\n", > > ret); > > tx_stats->tx_dropped++; > > - return ret; > > + return NETDEV_TX_BUSY; > > } > > skb->len = NETCP_MIN_PACKET_SIZE; > > } > > @@ -1329,7 +1330,7 @@ static int netcp_ndo_start_xmit(struct sk_buff *skb, struct net_device *ndev) > > if (desc) > > netcp_free_tx_desc_chain(netcp, desc, sizeof(*desc)); > > dev_kfree_skb(skb); > > - return ret; > > + return NETDEV_TX_BUSY; > > } > > I really think these should be returning NET_XMIT_DROP.
Yes, it seems here can be a little more changes then, will send new version later.
| |