lkml.org 
[lkml]   [2017]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: Clean up a tiny description mistake in kernel ld script
On Thu, 2 Feb 2017, Baoquan He wrote:

> Remove the redundent word "is".
>
> Signed-off-by: Baoquan He <bhe@redhat.com>
> ---
> arch/x86/kernel/vmlinux.lds.S | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/vmlinux.lds.S b/arch/x86/kernel/vmlinux.lds.S
> index e79f15f..f8f56b9 100644
> --- a/arch/x86/kernel/vmlinux.lds.S
> +++ b/arch/x86/kernel/vmlinux.lds.S
> @@ -8,8 +8,8 @@
> *
> *
> * Don't define absolute symbols until and unless you know that symbol
> - * value is should remain constant even if kernel image is relocated
> - * at run time. Absolute symbols are not relocated. If symbol value should
> + * value should remain constant even if kernel image is relocated at

And while at it we could make it a proper sentence:

... you know that the symbol value should .... even if the kernel ....

> + * run time. Absolute symbols are not relocated. If symbol value should

If the symbol value ...

> * change if kernel is relocated, make the symbol section relative and

if the kernel

> * put it inside the section definition.
> */
> --
> 2.5.5
>
>

\
 
 \ /
  Last update: 2017-02-10 12:48    [W:0.050 / U:0.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site