Messages in this thread | | | Date | Fri, 10 Feb 2017 11:30:30 +0530 | From | Viresh Kumar <> | Subject | Re: [PATCH V2 1/6] PM / QOS: Add default case to the switch |
| |
On 09-02-17, 15:24, Pavel Machek wrote: > On Thu 2017-02-09 09:11:47, Viresh Kumar wrote: > > The switch block handles all the QOS request types present today, but > > starts giving compilation warnings as soon as a new type is added and > > not handled in this. > > > > To prevent against that, add the default case as well and do a WARN from > > it. > > I'd say compilation-time warning is better than hmm.... stacktrace and memory leak > at runtime?
Of course we aren't going to allow a compilation warning for each and every platform that compiles this file. How do you wish to fix the issue then ?
-- viresh
| |