Messages in this thread | | | Date | Wed, 1 Feb 2017 20:40:06 +0200 | From | Jarkko Sakkinen <> | Subject | Re: [PATCH] tpm: fix type issues in tpm_getcap() |
| |
On Wed, Feb 01, 2017 at 07:53:47PM +0200, Jarkko Sakkinen wrote: > There are two type issues associated with tpm_getcap(). > > You must not do arithmetic with __be32 or __le32 types because sometimes > it results incorrect results. Calculations must be done only with data > that is in CPU byte order. This commit migrates tpm_getcap() to struct > tpm_buf in order to sort out these issues. > > The second issue is with struct cap_t as the size of the type bool is > assumed to be one byte. This commit sorts out the issue by changing the > type to u8. > > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> > --- > v2: > - Use struct tpm_buf. > - Merge the type change of 'owned' to this patch. > drivers/char/tpm/tpm-interface.c | 33 ++++++++++++++++++--------------- > drivers/char/tpm/tpm.h | 15 +-------------- > 2 files changed, 19 insertions(+), 29 deletions(-) > > diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-interface.c > index 423938e..7af1e8c 100644 > --- a/drivers/char/tpm/tpm-interface.c > +++ b/drivers/char/tpm/tpm-interface.c > @@ -480,31 +480,34 @@ static const struct tpm_input_header tpm_getcap_header = { > ssize_t tpm_getcap(struct tpm_chip *chip, u32 subcap_id, cap_t *cap, > const char *desc, size_t min_cap_length)
Last two parameters are in the wrong order (different than tpm_transmit_cmd).
/Jarkko
| |