lkml.org 
[lkml]   [2017]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] [RFC] sched: make DECLARE_COMPLETION_ONSTACK() work with clang
On Wed, Feb 1, 2017 at 5:34 PM, Arnd Bergmann <arnd@arndb.de> wrote:

> diff --git a/include/linux/completion.h b/include/linux/completion.h
> index fa5d3efaba56..5d5aaae3af43 100644
> --- a/include/linux/completion.h
> +++ b/include/linux/completion.h
> @@ -31,7 +31,7 @@ struct completion {
> { 0, __WAIT_QUEUE_HEAD_INITIALIZER((work).wait) }
>
> #define COMPLETION_INITIALIZER_ONSTACK(work) \
> - (*init_completion(&work))
> + ({ init_completion(&work); work; })
>
> /**
> * DECLARE_COMPLETION - declare and initialize a completion structure
> @@ -70,11 +70,10 @@ struct completion {
> * This inline function will initialize a dynamically created completion
> * structure.
> */
> -static inline struct completion *init_completion(struct completion *x)
> +static inline void init_completion(struct completion *x)
> {
> x->done = 0;
> init_waitqueue_head(&x->wait);
> - return x;
> }
>

I accidentally submitted the wrong patch, this is the revert of the
actual change.

Arnd

\
 
 \ /
  Last update: 2017-02-01 17:39    [W:0.032 / U:0.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site