Messages in this thread | | | From | KY Srinivasan <> | Subject | RE: [PATCHv2] tools: hv: hv_set_ifconfig.sh double check before setting ip | Date | Fri, 8 Dec 2017 19:04:26 +0000 |
| |
> -----Original Message----- > From: Olaf Hering [mailto:olaf@aepfle.de] > Sent: Friday, December 8, 2017 3:34 AM > To: Eduardo Otubo <otubo@redhat.com> > Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org; Stephen > Hemminger <sthemmin@microsoft.com>; Haiyang Zhang > <haiyangz@microsoft.com>; KY Srinivasan <kys@microsoft.com>; > vkuznets@redhat.com; mgamal@redhat.com; cavery@redhat.com > Subject: Re: [PATCHv2] tools: hv: hv_set_ifconfig.sh double check before > setting ip > > On Fri, Dec 08, Eduardo Otubo wrote: > > > tools/hv/hv_set_ifconfig.sh | 45 > +++++++++++++++++++++++++++++++++++++++++++-- > > 1 file changed, 43 insertions(+), 2 deletions(-) > > > + # let's wait for 3 minutes > > Was this codepath runtime tested? > > Last time this came up, the conclusion was that Windows terminates the > "KVP connection" after 60 seconds. After that, the VM must be rebooted > because the kernel does not deal with the long-running script. It is > also not clear what the kernel is supposed to do: either silently report > success and hope the scripts reports success one day, or report error > independent from what the script actually returns. New KVP requests > would need to be queued either way.
Agreed; 180 seconds is more than what the host is willing to wait.
K. Y > > > Olaf
| |