Messages in this thread | | | Date | Fri, 08 Dec 2017 10:44:49 -0500 (EST) | Subject | Re: [PATCH net-next V2] tuntap: fix possible deadlock when fail to register netdev | From | David Miller <> |
| |
From: "Michael S. Tsirkin" <mst@redhat.com> Date: Fri, 8 Dec 2017 06:43:44 +0200
> On Fri, Dec 08, 2017 at 12:02:30PM +0800, Jason Wang wrote: >> Private destructor could be called when register_netdev() fail with >> rtnl lock held. This will lead deadlock in tun_free_netdev() who tries >> to hold rtnl_lock. Fixing this by switching to use spinlock to >> synchronize. >> >> Fixes: 96f84061620c ("tun: add eBPF based queue selection method") >> Reported-by: Eric Dumazet <eric.dumazet@gmail.com> >> Cc: Eric Dumazet <eric.dumazet@gmail.com> >> Cc: Willem de Bruijn <willemb@google.com> >> Signed-off-by: Jason Wang <jasowang@redhat.com> > > Acked-by: Michael S. Tsirkin <mst@redhat.com>
Applied, thanks.
| |