lkml.org 
[lkml]   [2017]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] uio: Allow to take irq bottom-half into irq_handler with additional dt-binding
On Thu, Dec 7, 2017 at 10:16 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
>
> A: Because it messes up the order in which people normally read text.
> Q: Why is top-posting such a bad thing?
> A: Top-posting.
> Q: What is the most annoying thing in e-mail?
>
> A: No.
> Q: Should I include quotations after my reply?
>
> http://daringfireball.net/2007/07/on_top

Understood, rules are golden! :)

>
> The uio-phys driver does use DT bindings, so perhaps look at how those
> are defined.

UIO in general uses standard bindings (like "compatible", "reg",
"interrupt"), but the documentation part is completely missing. What I
was able to find in Kernel tree is a HOW-TO from Hans-Juergen Koch
dated 2006 and kobject reference on Embedding kobjects with UIO as an
example. I've created a new binding document under
Documentation/devicetree/bindings/uio/ and would submit it together
with updated patch in series.

If anyone happen to know which place I missed in the Kernel to look at
for uio dt-binding Documentation part - please point me out.

>
> Ok, that all seems like a good thing to have the ability to do here, you
> should mention it in the changelog text when you redo this patch.

Would be done!

I am planning to have all above corrected and re-submit the patch as
series with Documentation part included.

Cheers,
Andrey.

\
 
 \ /
  Last update: 2017-12-07 12:18    [W:0.037 / U:44.372 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site