[lkml]   [2017]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH][next] pinctrl: intel: ensure error return ret is initialized
On Mon, Dec 4, 2017 at 6:08 PM, Colin King <> wrote:

> From: Colin Ian King <>
> In the (unlikely) event that community->ngpps is zero, or if every
> gpp->gpio_base is less than zero, then an ininitialized value in
> ret is returned by function intel_gpio_add_pin_ranges. Fix this by
> ensuring ret is initialized to zero. It's a moot point, but I think
> it is worthwhile ensuring this corner case is fixed.
> Detected by CoverityScan, CID#1462415 ("Uninitialized scalar variable")
> Fixes: a60eac3239f0 ("pinctrl: intel: Allow custom GPIO base for pad groups")
> Signed-off-by: Colin Ian King <>

Patch applied with Mika's ACK.

Thanks for running these Coverity scans.

Linus Walleij

 \ /
  Last update: 2017-12-07 09:59    [W:0.036 / U:3.060 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site