lkml.org 
[lkml]   [2017]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH V6 3/7] device property: Introduce a common API to fetch device match data
From
Date
On 12/7/2017 7:29 AM, Sakari Ailus wrote:
> Hi Sinan,
>
> Thanks for the update.
>
> Just one small comment below.
>
[snip]

>>
>> struct fwnode_handle {
>> struct fwnode_handle *secondary;
>> @@ -66,6 +67,7 @@ struct fwnode_reference_args {
>> * endpoint node.
>> * @graph_get_port_parent: Return the parent node of a port node.
>> * @graph_parse_endpoint: Parse endpoint for port and endpoint id.
>> + * @get_match_data: Return the driver match data.
>
> Could you arrange the new get_match_data op closer to the other ops that
> don't deal with the graphs? Such as device_is_available. As the ops are
> dealing generally with fwnodes, I might call this device_get_match_data to
> explicitly mention it's for devices.

done

>
>> */
>> struct fwnode_operations {
>> void (*get)(struct fwnode_handle *fwnode);
>> @@ -101,6 +103,8 @@ struct fwnode_operations {
>> (*graph_get_port_parent)(struct fwnode_handle *fwnode);
>> int (*graph_parse_endpoint)(const struct fwnode_handle *fwnode,
>> struct fwnode_endpoint *endpoint);
>> + void *(*get_match_data)(const struct fwnode_handle *fwnode,
>> + struct device *dev);
>
> Same comment about the order here.

ok

>
>> };
>>
>> #define fwnode_has_op(fwnode, op) \
>> diff --git a/include/linux/property.h b/include/linux/property.h
>> index 6bebee1..01fa55b 100644
>> --- a/include/linux/property.h
>> +++ b/include/linux/property.h
>> @@ -275,6 +275,8 @@ int device_add_properties(struct device *dev,
>>
>> enum dev_dma_attr device_get_dma_attr(struct device *dev);
>>
>> +void *device_get_match_data(struct device *dev);
>> +
>> int device_get_phy_mode(struct device *dev);
>>
>> void *device_get_mac_address(struct device *dev, char *addr, int alen);
>


--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.

\
 
 \ /
  Last update: 2017-12-07 21:15    [W:0.053 / U:3.460 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site