Messages in this thread | | | Date | Thu, 07 Dec 2017 14:53:29 -0500 (EST) | Subject | Re: [PATCH net-next 1/6] net: mvpp2: only free the TSO header buffers when it was allocated | From | David Miller <> |
| |
From: Antoine Tenart <antoine.tenart@free-electrons.com> Date: Thu, 7 Dec 2017 09:48:58 +0100
> This patch adds a check to only free the TSO header buffer when its > allocation previously succeeded. > > Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
No, please keep this as a failure to bring up.
Even if you emit a log message, it is completely unintuitive to have netdev features change on the user just because of a memory allocation failure.
| |