lkml.org 
[lkml]   [2017]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net-next 1/6] net: mvpp2: only free the TSO header buffers when it was allocated
From
From: Antoine Tenart <antoine.tenart@free-electrons.com>
Date: Thu, 7 Dec 2017 09:48:58 +0100

> This patch adds a check to only free the TSO header buffer when its
> allocation previously succeeded.
>
> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>

No, please keep this as a failure to bring up.

Even if you emit a log message, it is completely unintuitive to
have netdev features change on the user just because of a memory
allocation failure.

\
 
 \ /
  Last update: 2017-12-07 20:54    [W:0.057 / U:9.280 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site