lkml.org 
[lkml]   [2017]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 1/2] at24: support eeproms that do not auto-rollover reads.
Hello,

On Thu, Dec 07, 2017 at 05:26:50PM +0100, Bartosz Golaszewski wrote:
> > + if (at24->chip.flags & AT24_FLAG_NO_RDROL) {
> > + bits = (at24->chip.flags & AT24_FLAG_ADDR16) ? 16 : 8;
>
> There's no need for braces around the ternary operator's condition.

Even if not required, I'd keep them for clearity.

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |

\
 
 \ /
  Last update: 2017-12-07 20:03    [W:0.056 / U:30.112 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site