lkml.org 
[lkml]   [2017]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/10] staging: ccree: remove inline qualifiers
On Thu, Dec 07, 2017 at 09:00:11AM +0200, Gilad Ben-Yossef wrote:
> On Mon, Dec 4, 2017 at 11:36 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > On Sun, Dec 03, 2017 at 01:58:12PM +0000, Gilad Ben-Yossef wrote:
> >> The ccree drivers was marking a lot of big functions in C file as
> >> static inline for no good reason. Remove the inline qualifier from
> >> any but the few truly single line functions.
> >>
> >
> > The compiler is free to ignore inline hints... It probably would make
> > single line functions inline anyway.
> >
>
> Yes. I think of it more as a note to the reader: "don't add stuff to
> this function. it is meant to be short and simple".
>

Ah. Fine.

regards,
dan carpenter

\
 
 \ /
  Last update: 2017-12-07 09:30    [W:0.044 / U:1.392 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site