lkml.org 
[lkml]   [2017]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL for 4.4 095/101] scsi: sd: change allow_restart to bool in sysfs interface
    Date
    From: weiping zhang <zhangweiping@didichuxing.com>

    [ Upstream commit 658e9a6dc1126f21fa417cd213e1cdbff8be0ba2 ]

    /sys/class/scsi_disk/0:2:0:0/allow_restart can be changed to 0
    unexpectedly by writing an invalid string such as the following:

    echo asdf > /sys/class/scsi_disk/0:2:0:0/allow_restart

    Signed-off-by: weiping zhang <zhangweiping@didichuxing.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
    ---
    drivers/scsi/sd.c | 6 +++++-
    1 file changed, 5 insertions(+), 1 deletion(-)

    diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
    index 19bfa7646c2b..dd72205ba298 100644
    --- a/drivers/scsi/sd.c
    +++ b/drivers/scsi/sd.c
    @@ -259,6 +259,7 @@ static ssize_t
    allow_restart_store(struct device *dev, struct device_attribute *attr,
    const char *buf, size_t count)
    {
    + bool v;
    struct scsi_disk *sdkp = to_scsi_disk(dev);
    struct scsi_device *sdp = sdkp->device;

    @@ -268,7 +269,10 @@ allow_restart_store(struct device *dev, struct device_attribute *attr,
    if (sdp->type != TYPE_DISK)
    return -EINVAL;

    - sdp->allow_restart = simple_strtoul(buf, NULL, 10);
    + if (kstrtobool(buf, &v))
    + return -EINVAL;
    +
    + sdp->allow_restart = v;

    return count;
    }
    --
    2.11.0
    \
     
     \ /
      Last update: 2017-12-07 17:27    [W:3.937 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site