lkml.org 
[lkml]   [2017]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 26/45] mm: remove duplicate includes
On Wed 06-12-17 22:52:37, Pravin Shedge wrote:
> These duplicate includes have been found with scripts/checkincludes.pl but
> they have been removed manually to avoid removing false positives.

I only see this one but I can see this is a series of 45 patches. Is
this really the best way to apply a change like this? Why not do it in a
single patch?

Other than that the patch looks correct.

> Signed-off-by: Pravin Shedge <pravin.shedge4linux@gmail.com>
> ---
> mm/userfaultfd.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/mm/userfaultfd.c b/mm/userfaultfd.c
> index 8119270..39791b8 100644
> --- a/mm/userfaultfd.c
> +++ b/mm/userfaultfd.c
> @@ -16,7 +16,6 @@
> #include <linux/userfaultfd_k.h>
> #include <linux/mmu_notifier.h>
> #include <linux/hugetlb.h>
> -#include <linux/pagemap.h>
> #include <linux/shmem_fs.h>
> #include <asm/tlbflush.h>
> #include "internal.h"
> --
> 2.7.4
>

--
Michal Hocko
SUSE Labs

\
 
 \ /
  Last update: 2017-12-06 18:44    [W:0.222 / U:0.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site