lkml.org 
[lkml]   [2017]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC PATCH 2/5] perf jevents: add support for arch recommended events
From
Date
On 06/12/2017 13:37, Jiri Olsa wrote:
> On Wed, Dec 06, 2017 at 12:13:16AM +0800, John Garry wrote:
>
> SNIP
>
>> ---
>> tools/perf/pmu-events/jevents.c | 215 ++++++++++++++++++++++++++++++++++++----
>> 1 file changed, 198 insertions(+), 17 deletions(-)
>>
>> diff --git a/tools/perf/pmu-events/jevents.c b/tools/perf/pmu-events/jevents.c
>> index a0d489e..a820ed4 100644
>> --- a/tools/perf/pmu-events/jevents.c
>> +++ b/tools/perf/pmu-events/jevents.c
>> @@ -42,6 +42,7 @@
>> #include <dirent.h>
>> #include <sys/time.h> /* getrlimit */
>> #include <sys/resource.h> /* getrlimit */
>> +#include <sys/queue.h>
>> #include <ftw.h>
>> #include <sys/stat.h>
>> #include "jsmn.h"
>> @@ -366,6 +367,94 @@ static int print_events_table_entry(void *data, char *name, char *event,
>> return 0;
>> }
>>
>> +struct event_struct {
>> + char *name;
>> + char *event;
>> + char *desc;
>> + char *long_desc;
>> + char *pmu;
>> + char *unit;
>> + char *perpkg;
>> + char *metric_expr;
>> + char *metric_name;
>> + char *metric_group;
>> + LIST_ENTRY(event_struct) list;
>
> is there any reason you don't use the 'struct list_head' ?
> I dont think we want another thingie involved for lists

Hi jirka,

The linux kernel headers are not used for jevents tool. I would rather
use them if possible...

Thanks,
John

>
> jirka
>
> .
>


\
 
 \ /
  Last update: 2017-12-06 15:41    [W:0.132 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site