lkml.org 
[lkml]   [2017]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Scheduler: Removed first parameter from prepare_lock_switch
On Tue, Dec 05, 2017 at 12:02:00PM -0200, rodrigosiqueira wrote:
> The first parameter of prepare_lock_switch (kernel/sched/sched.h) is not
> used anymore. Commit c55f5158f removed the code that use the first
> parameter and function prepare_lock_switch is only used in
> prepare_task_switch (kernel/sched/core.c)

Yes, this is correct. However it had me looking at that code and pretty
much everything else is completely wrong :-)

That is, its functionally correct (probably), but the function name is
not descriptive of what the function does and the comment is just plain
wrong.

Also, since both functions are only used in core.c we should probably
move them there.

Do you think you can fix all that as well?

\
 
 \ /
  Last update: 2017-12-06 13:15    [W:0.996 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site