lkml.org 
[lkml]   [2017]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] cpu/hotplug: Fix state name in takedown_cpu comment
    Date
    CPUHP_AP_SCHED_MIGRATE_DYING doesn't exist, it looks like this was
    supposed to refer to CPUHP_AP_SCHED_STARTING's teardown callback
    i.e. sched_cpu_dying.

    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Ingo Molnar <mingo@kernel.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
    Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
    Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>
    Cc: Quentin Perret <quentin.perret@arm.com>
    ---
    kernel/cpu.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/kernel/cpu.c b/kernel/cpu.c
    index 04892a82f6ac..944c7efdf092 100644
    --- a/kernel/cpu.c
    +++ b/kernel/cpu.c
    @@ -780,8 +780,8 @@ static int takedown_cpu(unsigned int cpu)
    BUG_ON(cpu_online(cpu));

    /*
    - * The CPUHP_AP_SCHED_MIGRATE_DYING callback will have removed all
    - * runnable tasks from the cpu, there's only the idle task left now
    + * The teardown callback for CPUHP_AP_SCHED_STARTING will have removed
    + * all runnable tasks from the cpu, there's only the idle task left now
    * that the migration thread is done doing the stop_machine thing.
    *
    * Wait for the stop thread to go away.
    --
    2.14.1
    \
     
     \ /
      Last update: 2017-12-06 11:59    [W:4.236 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site