lkml.org 
[lkml]   [2017]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v8 10/13] dt-bindings: Add qcom slimbus controller bindings
From
Date


On 04/12/17 21:28, Rob Herring wrote:
> On Thu, Nov 30, 2017 at 05:41:57PM +0000, srinivas.kandagatla@linaro.org wrote:
>> From: Sagar Dharia <sdharia@codeaurora.org>
>>
>> This patch add device tree bindings for Qualcomm slimbus controller.
>>
>> Signed-off-by: Sagar Dharia <sdharia@codeaurora.org>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>> ---
>> .../devicetree/bindings/slimbus/slim-qcom-ctrl.txt | 39 ++++++++++++++++++++++
>> 1 file changed, 39 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/slimbus/slim-qcom-ctrl.txt
>>
>> + - clocks : Interface and core clocks used by this SLIMbus controller
>> + - clock-names : Required clock-name entries are:
>> + "iface_clk" : Interface clock for this controller
>> + "core_clk" : Interrupt for controller core's BAM
>
> Doesn't match the example. You should drop the '_clk'. With that,
>

Thanks for the Reviewed-by tag, I will fix the above in next version.

> Reviewed-by: Rob Herring <robh@kernel.org>

\
 
 \ /
  Last update: 2017-12-05 23:03    [W:0.065 / U:0.768 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site