Messages in this thread | | | From | Vivien Didelot <> | Subject | Re: [PATCH net-next 0/5] net: dsa: use per-port upstream port | Date | Tue, 05 Dec 2017 14:57:18 -0500 |
| |
Hi David,
David Miller <davem@davemloft.net> writes:
> From: Vivien Didelot <vivien.didelot@savoirfairelinux.com> > Date: Mon, 4 Dec 2017 12:34:52 -0500 > >> An upstream port is a local switch port used to reach a CPU port. >> >> DSA still considers a unique CPU port in the whole switch fabric and >> thus return a unique upstream port for a given switch. This is wrong in >> a multiple CPU ports environment. >> >> We are now switching to using the dedicated CPU port assigned to each >> port in order to get rid of the deprecated unique tree CPU port. >> >> This patchset makes the dsa_upstream_port() helper take a port argument >> and goes one step closer complete support for multiple CPU ports. > > Please adhere to reverse-christmas-tree for variable declarations in > these changes.
Totally makes sense for this month of the year, I'm replanting a v2!
Thanks,
Vivien
| |