lkml.org 
[lkml]   [2017]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] regulator: sc2731: Add regulator driver to support Spreadtrum SC2731 PMIC
Hi Mark,

On Fri, Dec 01, 2017 at 01:01:37PM +0000, Mark Brown wrote:
> On Fri, Dec 01, 2017 at 04:58:16PM +0800, Erick Chen wrote:
>
> > +static const struct of_device_id sc2731_regulator_of_match[] = {
> > + {.compatible = "sprd,sc2731-regulator",},
> > + {}
> > +};
> > +MODULE_DEVICE_TABLE(of, sc2731_regulator_of_match);
>
> This looks like a subdriver for one specific device that can't be reused
> with anything else as it's specific to an individual device so I'd not
> expect it to appear as a separate thing in DT - the way Linux splits
> things up might not map well onto other OSs and may even change in
> future versions of Linux (look at all the audio drivers with clock
> controllers in them for example). I'd expect the MFD to just register
> the subdevice without needing it to appear in the DT.
>

Make sense, i will remove the of_device_id table in next version.

> > +subsys_initcall(sc2731_regulator_init);
> > +module_exit(sc2731_regulator_exit);
>
> Why not module_platform_driver()? Deferred probe should sort out probe
> order.

On some Spreadtrum old platforms, we need to power on the CPU cores ASAP.
But now this issue had been fixed after some investigation, so we can change
subsys_initcall() to module_init() level as you suggested.

Very appreciated for your helpful comments.

\
 
 \ /
  Last update: 2017-12-04 10:12    [W:0.044 / U:0.492 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site