lkml.org 
[lkml]   [2017]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Staging: pi433: fix brace coding style issues in pi433_if.c
From
Date
On 12/04/2017 10:32 AM, Dan Carpenter wrote:

> On Sat, Dec 02, 2017 at 10:05:20PM +0100, Tomas Marek wrote:
>> @@ -578,13 +546,9 @@ static irqreturn_t DIO1_irq_handler(int irq, void *dev_id)
>> SET_CHECKED(rf69_set_mode(spi, standby)); /* this clears the fifo */
>> SET_CHECKED(rf69_set_fifo_threshold(spi, FIFO_THRESHOLD));
>> if (tx_cfg.enable_length_byte == optionOn)
>> - {
>> SET_CHECKED(rf69_set_payload_length(spi, size * tx_cfg.repetitions));
>> - }
>> else
>> - {
>> SET_CHECKED(rf69_set_payload_length(spi, 0));
>> - }
>>
> You can't delete the curly braces here because SET_CHECKED() is utter
> garbage. SET_CHECKED() needs to be wrapped in a do-while(0) loop. But
> someone sent a patch to delete it entirely which is even better.
>
> regards,
> dan carpenter
>
Thanks for pointing that out. I already noticed that during implementation
of another suggestion too. I will revert this change in v2 of the patch. Anyway,
as you wrote there is the patch "[PATCHv2] staging: pi433: pi433_if.c remove
SET_CHECKED macro" which removes this macro completely and solve the
styling issue.

Best regards,
Tomas Marek

\
 
 \ /
  Last update: 2017-12-04 20:46    [W:0.031 / U:0.032 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site