lkml.org 
[lkml]   [2017]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH V5 4/7] OF: properties: Implement get_match_data() callback
From
Date
On 12/4/2017 11:23 AM, Rob Herring wrote:
> On Fri, Dec 1, 2017 at 10:27 PM, Sinan Kaya <okaya@codeaurora.org> wrote:
>> Now that we have a get_match_data() callback as part of the firmware node,
>> implement the OF specific piece for it.
>>
>> Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
>> ---
>> drivers/of/property.c | 17 +++++++++++++++++
>> 1 file changed, 17 insertions(+)
>>
..

>>
>> +void *of_fwnode_get_match_data(const struct fwnode_handle *fwnode,
>> + const struct device_driver *drv)
>> +{
>> + const struct device_node *node = to_of_node(fwnode);
>> + const struct of_device_id *match;
>> +
>> + if (!node)
>> + return NULL;
>
> of_match_node checks this.

I see a check for the matches argument but not for the node argument.
Am I missing something?

>
>> +
>> + match = of_match_node(drv->of_match_table, node);
>> + if (!match)
>> + return NULL;
>> +
>> + return (void *)match->data;
>
> Don't need a cast here.

I can fix this.

>
> of_device_get_match_data() already does most of this, but getting a
> device ptr from fwnode_handle may not be possible?

I couldn't figure out how to do that. Do you have a suggestion?
I have been looking for examples with no luck.

>
> Rob
>


--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.

\
 
 \ /
  Last update: 2017-12-04 19:06    [W:0.042 / U:0.592 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site