Messages in this thread | | | Subject | Re: [PATCH] drm/i915: Mark expected switch fall-throughs | From | Joonas Lahtinen <> | Date | Mon, 04 Dec 2017 12:35:05 +0200 |
| |
On Mon, 2017-11-27 at 16:17 -0600, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through.
I have to say I'm totally not sold on regexps matching comment contents. Was something more explicit ever considered? Like:
#define FALLTHROUGH __attribute__((fallthrough));
With the appropriate version checks, of course.
Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation
| |