lkml.org 
[lkml]   [2017]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] security: keys: remove redundant assignment to key_ref
On Mon, 4 Dec 2017, Colin King wrote:

> From: Colin Ian King <colin.king@canonical.com>
>
> Variable key_ref is being assigned a value that is never read;
> key_ref is being re-assigned a few statements later. Hence this
> assignment is redundant and can be removed.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

I think a general cleanup in that function to make all of these follow the
pattern:

if (something) {
key_ref = ERR_PTR(-error);
goto error;
}

rather than unconditionally setting the error first, would be better, but
this is a clear enough fix on its own.

Reviewed-by: James Morris <james.l.morris@oracle.com>


--
James Morris
<james.l.morris@oracle.com>

\
 
 \ /
  Last update: 2017-12-05 03:09    [W:0.030 / U:1.836 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site