lkml.org 
[lkml]   [2017]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6 4/6] dt: bindings: lp8860: Update the bindings to the standard
On Sun, Dec 03, 2017 at 02:27:20PM +0100, Jacek Anaszewski wrote:
> Dan,
>
> On 12/01/2017 05:56 PM, Dan Murphy wrote:
> > Update the lp8860 dt binding to the LED standard where
> > the LED should have a child node and also adding a
> > LED trigger entry.
> >
> > Signed-off-by: Dan Murphy <dmurphy@ti.com>
> > ---
> >
> > v6 - New patch to fix binding documentation
> >
> > Documentation/devicetree/bindings/leds/leds-lp8860.txt | 15 +++++++++++----
> > 1 file changed, 11 insertions(+), 4 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/leds/leds-lp8860.txt b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
> > index aad38dd94d4b..4cf396de6eba 100644
> > --- a/Documentation/devicetree/bindings/leds/leds-lp8860.txt
> > +++ b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
> > @@ -12,17 +12,24 @@ Required properties:
> > - label - Used for naming LEDs
> >
> > Optional properties:
> > - - enable-gpio - gpio pin to enable/disable the device.
> > - - supply - "vled" - LED supply
> > + - enable-gpios : gpio pin to enable/disable the device.
> > + - vled-supply : LED supply
> > + - label : see Documentation/devicetree/bindings/leds/common.txt
> > + - linux,default-trigger : (optional)
> > + see Documentation/devicetree/bindings/leds/common.txt
> >
> > Example:
> >
> > -leds: leds@6 {
> > +lp8860@2d {

leds@2d

> > compatible = "ti,lp8860";
> > reg = <0x2d>;
> > - label = "display_cluster";
> > enable-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>;
> > vled-supply = <&vbatt>;
> > +
> > + backlight: backlight@0 {

unit-address requires a 'reg' property. Building your dts files with W=1
will tell you this.

> > + label = "backlight_cluster";
>
> You'll need to change this to:
>
> label = "white:backlight_cluster"
>
> Please always cc your patches with DT bindings to
> devicetree@vger.kernel.org and related maintainers.
>
> > + linux,default-trigger = "backlight";
> > + };
> > }
> >
> > For more product information please see the link below:
> >
>
> --
> Best regards,
> Jacek Anaszewski

\
 
 \ /
  Last update: 2017-12-04 23:36    [W:0.057 / U:1.948 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site