Messages in this thread | | | Date | Sat, 30 Dec 2017 19:11:54 +0100 | From | Wolfram Sang <> | Subject | Re: [RESEND,3/4] i2c: mpc: fix PORDEVSR2 mask for MPC8533/44 |
| |
> /* > * Map and check POR Device Status Register 2 > - * (PORDEVSR2) at 0xE0014 > + * (PORDEVSR2) at 0xE0014. Note than while MPC8533 > + * and MPC8544 indicate SEC frequency ratio > + * configuration as bit 26 in PORDEVSR2, other MPC8xxx > + * parts may store it differently or may not have it > + * at all.
So given this comment which you added...
> */ > reg = ioremap(get_immrbase() + *prop + 0x14, 0x4); > if (!reg) > printk(KERN_ERR > "Error: couldn't map PORDEVSR2\n"); > else > - val = in_be32(reg) & 0x00000080; /* sec-cfg */ > + val = in_be32(reg) & 0x00000020; /* sec-cfg */
... are you really sure there is no ancient device which needs the 0x00000080?
[unhandled content-type:application/pgp-signature]
| |