lkml.org 
[lkml]   [2017]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] ipc, mqueue: lazy call kern_mount_data in new namespaces
Hi Giuseppe,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v4.15-rc2 next-20171201]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Giuseppe-Scrivano/ipc-mqueue-lazy-call-kern_mount_data-in-new-namespaces/20171203-201041
config: i386-randconfig-c0-12032036 (attached as .config)
compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025
reproduce:
# save the attached .config to linux build tree
make ARCH=i386

All errors (new ones prefixed by >>):

ipc/namespace.c: In function 'create_ipc_ns':
>> ipc/namespace.c:68:8: error: too many arguments to function 'mq_init_ns'
err = mq_init_ns(ns, false);
^~~~~~~~~~
In file included from ipc/namespace.c:9:0:
include/linux/ipc_namespace.h:119:19: note: declared here
static inline int mq_init_ns(struct ipc_namespace *ns) { return 0; }
^~~~~~~~~~
In file included from include/linux/kernel.h:10:0,
from include/linux/list.h:9,
from include/linux/preempt.h:11,
from include/linux/spinlock.h:51,
from include/linux/ipc.h:5,
from ipc/namespace.c:7:
ipc/namespace.c: At top level:
include/linux/compiler.h:64:4: warning: '______f' is static but declared in inline function 'strcpy' which is not static
______f = { \
^
include/linux/compiler.h:56:23: note: in expansion of macro '__trace_if'
#define if(cond, ...) __trace_if( (cond , ## __VA_ARGS__) )
^~~~~~~~~~
include/linux/string.h:422:2: note: in expansion of macro 'if'
if (p_size == (size_t)-1 && q_size == (size_t)-1)
^~
include/linux/compiler.h:64:4: warning: '______f' is static but declared in inline function 'kmemdup' which is not static
______f = { \
^
include/linux/compiler.h:56:23: note: in expansion of macro '__trace_if'
#define if(cond, ...) __trace_if( (cond , ## __VA_ARGS__) )
^~~~~~~~~~
include/linux/string.h:412:2: note: in expansion of macro 'if'
if (p_size < size)
^~
include/linux/compiler.h:64:4: warning: '______f' is static but declared in inline function 'kmemdup' which is not static
______f = { \
^
include/linux/compiler.h:56:23: note: in expansion of macro '__trace_if'
#define if(cond, ...) __trace_if( (cond , ## __VA_ARGS__) )
^~~~~~~~~~
include/linux/string.h:410:2: note: in expansion of macro 'if'
if (__builtin_constant_p(size) && p_size < size)
^~
include/linux/compiler.h:64:4: warning: '______f' is static but declared in inline function 'memchr_inv' which is not static
______f = { \
^
include/linux/compiler.h:56:23: note: in expansion of macro '__trace_if'
#define if(cond, ...) __trace_if( (cond , ## __VA_ARGS__) )
^~~~~~~~~~
include/linux/string.h:401:2: note: in expansion of macro 'if'
if (p_size < size)
^~
include/linux/compiler.h:64:4: warning: '______f' is static but declared in inline function 'memchr_inv' which is not static
______f = { \
^
include/linux/compiler.h:56:23: note: in expansion of macro '__trace_if'
#define if(cond, ...) __trace_if( (cond , ## __VA_ARGS__) )
^~~~~~~~~~
include/linux/string.h:399:2: note: in expansion of macro 'if'
if (__builtin_constant_p(size) && p_size < size)
^~
include/linux/compiler.h:64:4: warning: '______f' is static but declared in inline function 'memchr' which is not static
______f = { \
^
include/linux/compiler.h:56:23: note: in expansion of macro '__trace_if'
#define if(cond, ...) __trace_if( (cond , ## __VA_ARGS__) )
^~~~~~~~~~
include/linux/string.h:390:2: note: in expansion of macro 'if'
if (p_size < size)
^~
include/linux/compiler.h:64:4: warning: '______f' is static but declared in inline function 'memchr' which is not static
______f = { \
^
include/linux/compiler.h:56:23: note: in expansion of macro '__trace_if'
#define if(cond, ...) __trace_if( (cond , ## __VA_ARGS__) )
^~~~~~~~~~
include/linux/string.h:388:2: note: in expansion of macro 'if'
if (__builtin_constant_p(size) && p_size < size)
^~
include/linux/compiler.h:64:4: warning: '______f' is static but declared in inline function 'memcmp' which is not static
______f = { \
^
include/linux/compiler.h:56:23: note: in expansion of macro '__trace_if'
#define if(cond, ...) __trace_if( (cond , ## __VA_ARGS__) )
^~~~~~~~~~
include/linux/string.h:380:2: note: in expansion of macro 'if'
if (p_size < size || q_size < size)
^~
include/linux/compiler.h:64:4: warning: '______f' is static but declared in inline function 'memcmp' which is not static
______f = { \
^
include/linux/compiler.h:56:23: note: in expansion of macro '__trace_if'
#define if(cond, ...) __trace_if( (cond , ## __VA_ARGS__) )
^~~~~~~~~~
include/linux/string.h:377:3: note: in expansion of macro 'if'
if (q_size < size)
^~
include/linux/compiler.h:64:4: warning: '______f' is static but declared in inline function 'memcmp' which is not static
______f = { \
^
include/linux/compiler.h:56:23: note: in expansion of macro '__trace_if'
#define if(cond, ...) __trace_if( (cond , ## __VA_ARGS__) )
^~~~~~~~~~

vim +/mq_init_ns +68 ipc/namespace.c

31
32 static struct ipc_namespace *create_ipc_ns(struct user_namespace *user_ns,
33 struct ipc_namespace *old_ns)
34 {
35 struct ipc_namespace *ns;
36 struct ucounts *ucounts;
37 int err;
38
39 err = -ENOSPC;
40 ucounts = inc_ipc_namespaces(user_ns);
41 if (!ucounts)
42 goto fail;
43
44 err = -ENOMEM;
45 ns = kmalloc(sizeof(struct ipc_namespace), GFP_KERNEL);
46 if (ns == NULL)
47 goto fail_dec;
48
49 err = ns_alloc_inum(&ns->ns);
50 if (err)
51 goto fail_free;
52 ns->ns.ops = &ipcns_operations;
53
54 refcount_set(&ns->count, 1);
55 ns->user_ns = get_user_ns(user_ns);
56 ns->ucounts = ucounts;
57
58 err = sem_init_ns(ns);
59 if (err)
60 goto fail_put;
61 err = msg_init_ns(ns);
62 if (err)
63 goto fail_destroy_sem;
64 err = shm_init_ns(ns);
65 if (err)
66 goto fail_destroy_msg;
67
> 68 err = mq_init_ns(ns, false);
69 if (err)
70 goto fail_destroy_shm;
71
72 return ns;
73
74 fail_destroy_shm:
75 shm_exit_ns(ns);
76 fail_destroy_msg:
77 msg_exit_ns(ns);
78 fail_destroy_sem:
79 sem_exit_ns(ns);
80 fail_put:
81 put_user_ns(ns->user_ns);
82 ns_free_inum(&ns->ns);
83 fail_free:
84 kfree(ns);
85 fail_dec:
86 dec_ipc_namespaces(ucounts);
87 fail:
88 return ERR_PTR(err);
89 }
90

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2017-12-03 19:44    [W:0.036 / U:0.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site