lkml.org 
[lkml]   [2017]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RESEND PATCH 1/1] Coccinelle: array_size: report even if include is missing


On Fri, 29 Dec 2017, Jérémy Lefaure wrote:

> Rule r does not depend on rule i (which is the include of
> linux/kernel.h) so the output should not depend on i in
> org and report mode.
>
> Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr>
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>

Re-Acked-by: Julia Lawall <julia.lawall@lip6.fr>


> ---
>
> scripts/coccinelle/misc/array_size.cocci | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/coccinelle/misc/array_size.cocci b/scripts/coccinelle/misc/array_size.cocci
> index 6ec05710b017..09520f0941f0 100644
> --- a/scripts/coccinelle/misc/array_size.cocci
> +++ b/scripts/coccinelle/misc/array_size.cocci
> @@ -72,13 +72,13 @@ position p;
> (sizeof(E)@p /sizeof(T))
> )
>
> -@script:python depends on i&&org@
> +@script:python depends on org@
> p << r.p;
> @@
>
> coccilib.org.print_todo(p[0], "WARNING should use ARRAY_SIZE")
>
> -@script:python depends on i&&report@
> +@script:python depends on report@
> p << r.p;
> @@
>
> --
> 2.14.1
>
>
\
 
 \ /
  Last update: 2017-12-29 19:22    [W:0.024 / U:20.872 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site