lkml.org 
[lkml]   [2017]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 126/204] Input: ti_am335x_tsc - fix incorrect step config for 5 wire touchscreen
    3.16.52-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Jeff Lance <j-lance1@ti.com>

    commit cf5dd48907bebaefdb43a8ca079be77e8da2cb20 upstream.

    Step config setting for 5 wire touchscreen is incorrect for Y coordinates.
    It was broken while we moved to DT. If you look close at the offending
    commit bb76dc09ddfc ("input: ti_am33x_tsc: Order of TSC wires, made
    configurable"), the change was:

    - STEPCONFIG_XNP | STEPCONFIG_YPN;
    + ts_dev->bit_xn | ts_dev->bit_yp;

    while bit_xn = STEPCONFIG_XNN and bit_yp = STEPCONFIG_YNN. Not quite the
    same.

    Fixes: bb76dc09ddfc ("input: ti_am33x_tsc: Order of TSC wires, made configurable")
    Signed-off-by: Jeff Lance <j-lance1@ti.com>
    [vigneshr@ti.com: Rebase to v4.14-rc1]
    Signed-off-by: Vignesh R <vigneshr@ti.com>
    Reviewed-by: Michael Nazzareno Trimarchi <michael@amarulasolutions.com>
    Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/input/touchscreen/ti_am335x_tsc.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/input/touchscreen/ti_am335x_tsc.c
    +++ b/drivers/input/touchscreen/ti_am335x_tsc.c
    @@ -157,7 +157,7 @@ static void titsc_step_config(struct tit
    break;
    case 5:
    config |= ts_dev->bit_xp | STEPCONFIG_INP_AN4 |
    - ts_dev->bit_xn | ts_dev->bit_yp;
    + STEPCONFIG_XNP | STEPCONFIG_YPN;
    break;
    case 8:
    config |= ts_dev->bit_yp | STEPCONFIG_INP(ts_dev->inp_xp);
    \
     
     \ /
      Last update: 2017-12-28 18:40    [W:2.452 / U:1.652 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site