Messages in this thread | | | Date | Thu, 28 Dec 2017 13:34:14 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH v2] x86/platform/intel-mid: Revert "Make 'bt_sfi_data' const" |
| |
* Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> v2: low the tone of accusation that this made a regression
BTW., don't worry about that aspect too much: after a long debugging session it's pretty natural to be upset at whoever introduced a regression.
( In fact a number of times I too got upset at the moron who wrote a particular piece of buggy code, only for 'git annotate' to remind me that the moron was me. )
I personally just ignore the emotional attributes, and I usually edit changelogs accordingly as well so the temporary state of mind of finding a regression doesn't trickle upstream.
Plus in this particular case if we can help type propagation for driver data to become a bit cleaner then the kernel project has gained a bit through all this pain.
Thanks,
Ingo
| |