lkml.org 
[lkml]   [2017]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/4] libbpf: break loop earlier
From
Date
Hello,

On Wed, 2017-12-27 at 11:00 -0800, Alexei Starovoitov wrote:
> On Wed, Dec 27, 2017 at 07:02:28PM +0100, Eric Leblond wrote:
> > Get out of the loop when we have a match.
> >
> > Signed-off-by: Eric Leblond <eric@regit.org>
> > ---
> > tools/lib/bpf/libbpf.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
> > index 5fe8aaa2123e..d263748aa341 100644
> > --- a/tools/lib/bpf/libbpf.c
> > +++ b/tools/lib/bpf/libbpf.c
> > @@ -412,6 +412,7 @@ bpf_object__init_prog_names(struct bpf_object
> > *obj)
> > prog->section_name);
> > return -LIBBPF_ERRNO__LIBELF;
> > }
> > + break;
>
> why this is needed?

It was just cosmetic, no related bug.

> The top of the loop is:
> for (si = 0; si < symbols->d_size / sizeof(GElf_Sym) && !name;
>
> so as soon as name is found the loop will exit.

OK, I've missed that. Please disregard this patch.

BR,
--
Eric Leblond <eric@regit.org>

\
 
 \ /
  Last update: 2017-12-27 21:31    [W:0.035 / U:42.284 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site