lkml.org 
[lkml]   [2017]   [Dec]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.18 04/38] r8152: fix the list rx_done may be used without initialization
    Date
    3.18-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: hayeswang <hayeswang@realtek.com>


    [ Upstream commit 98d068ab52b4b11d403995ed14154660797e7136 ]

    The list rx_done would be initialized when the linking on occurs.
    Therefore, if a napi is scheduled without any linking on before,
    the following kernel panic would happen.

    BUG: unable to handle kernel NULL pointer dereference at 000000000000008
    IP: [<ffffffffc085efde>] r8152_poll+0xe1e/0x1210 [r8152]
    PGD 0
    Oops: 0002 [#1] SMP

    Signed-off-by: Hayes Wang <hayeswang@realtek.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/usb/r8152.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/net/usb/r8152.c
    +++ b/drivers/net/usb/r8152.c
    @@ -1252,6 +1252,7 @@ static int alloc_all_mem(struct r8152 *t
    spin_lock_init(&tp->tx_lock);
    INIT_LIST_HEAD(&tp->rx_done);
    INIT_LIST_HEAD(&tp->tx_free);
    + INIT_LIST_HEAD(&tp->rx_done);
    skb_queue_head_init(&tp->tx_queue);

    for (i = 0; i < RTL8152_MAX_RX; i++) {

    \
     
     \ /
      Last update: 2017-12-22 11:56    [W:5.685 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site