lkml.org 
[lkml]   [2017]   [Dec]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 24/78] bna: integer overflow bug in debugfs
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>


    [ Upstream commit 13e2d5187f6b965ba3556caedb914baf81b98ed2 ]

    We could allocate less memory than intended because we do:

    bnad->regdata = kzalloc(len << 2, GFP_KERNEL);

    The shift can overflow leading to a crash. This is debugfs code so the
    impact is very small.

    Fixes: 7afc5dbde091 ("bna: Add debugfs interface.")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Acked-by: Rasesh Mody <rasesh.mody@cavium.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/brocade/bna/bnad_debugfs.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/net/ethernet/brocade/bna/bnad_debugfs.c
    +++ b/drivers/net/ethernet/brocade/bna/bnad_debugfs.c
    @@ -324,7 +324,7 @@ bnad_debugfs_write_regrd(struct file *fi
    return PTR_ERR(kern_buf);

    rc = sscanf(kern_buf, "%x:%x", &addr, &len);
    - if (rc < 2) {
    + if (rc < 2 || len > UINT_MAX >> 2) {
    netdev_warn(bnad->netdev, "failed to read user buffer\n");
    kfree(kern_buf);
    return -EINVAL;

    \
     
     \ /
      Last update: 2017-12-22 11:49    [W:2.292 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site